Draft
Conversation
Contributor
Author
|
/ci authorize |
Contributor
Author
|
/ci authorize |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #19847 +/- ##
===========================================
+ Coverage 75.8% 81.0% +5.2%
===========================================
Files 684 140 -544
Lines 73114 7321 -65793
===========================================
- Hits 55431 5934 -49497
+ Misses 17539 1387 -16152
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
maurelian
reviewed
Apr 1, 2026
maurelian
reviewed
Apr 1, 2026
Contributor
Author
|
/ci authorize |
0xiamflux
reviewed
Apr 2, 2026
packages/contracts-bedrock/scripts/upgrade/GenerateNUTBundle.s.sol
Outdated
Show resolved
Hide resolved
0xiamflux
reviewed
Apr 2, 2026
packages/contracts-bedrock/scripts/upgrade/GenerateNUTBundle.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrade/GenerateNUTBundle.s.sol
Outdated
Show resolved
Hide resolved
| if (records[i].sysFeatureGate != 0) { | ||
| // If the feature on the gate is not present on the bitmap, the predeploy is not supported. | ||
| if ( | ||
| DevFeatures.isDevFeatureEnabled(records[i].sysFeatureGate, Features.CUSTOM_GAS_TOKEN) |
Contributor
There was a problem hiding this comment.
Is this the proper way to check for system features status? Dev Feature Flags are bitmaps while Features are human readable tags with a status stored somewhere as a boolean flag.
Contributor
Author
There was a problem hiding this comment.
oh you're right. So, do I need to separate features in different arguments?
maurelian
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unified predeploys source of truth
Closes #19260